<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6138#discussion_r2172413582">app/controllers/confirmations_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController
before_action :require_cookies, :only => [:confirm]
def confirm
+ # The post happens in confirm.html.erb and user.js
</pre>
<p dir="auto">I don't think this is very useful - even if you accept it's true right now, and that depends on how you define "happens" exactly, there's no guarantee that those locations will stay the same and nobody will find and update this if they change one of those files.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6138#pullrequestreview-2967198355">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ3UF5QFTEZLTGZYST3FVW77AVCNFSM6AAAAACAJJKZ6OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRXGE4TQMZVGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMVQKU4YJMGQFNH3NT3FVW77A5CNFSM6AAAAACAJJKZ6OWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVQ3PNJG.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6138/review/2967198355</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6138#pullrequestreview-2967198355",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6138#pullrequestreview-2967198355",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>