<p></p>
<p><b>@tordans</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6138#discussion_r2173116294">app/controllers/confirmations_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -14,6 +14,7 @@ class ConfirmationsController < ApplicationController
   before_action :require_cookies, :only => [:confirm]
 
   def confirm
+    # The post happens in confirm.html.erb and user.js
</pre>
<p dir="auto">Please feel free to improve the wording and even remove this line.</p>
<p dir="auto">I want to point out, however, that in my understanding the form in <code class="notranslate">confirm.html.erb</code> and the JS in <code class="notranslate">user.js</code> that auto-submits the form is tightly coupled to the <code class="notranslate">if request.post?</code> in <code class="notranslate">#confirm</code> <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6138/files/0e160369a76b968b4fc71468f06506aabe8693c7#diff-961c5d7e0310073ca00d502eda2687808102441be660a654cab29645fbcea019R18">https://github.com/openstreetmap/openstreetmap-website/pull/6138/files/0e160369a76b968b4fc71468f06506aabe8693c7#diff-961c5d7e0310073ca00d502eda2687808102441be660a654cab29645fbcea019R18</a><br>
So relevant changes to the flow will have to touch this code and give an opportunity to update the comment.</p>
<p dir="auto">I can say that when I spend about 1.5 hours pairing on this issue (2 people: 3 h) we did not expect this kind of flow where an OAuth <code class="notranslate">POST</code> gets redirected to a html page which auto submits a form to step into the <code class="notranslate">if request.post?</code> branch. It took us quite a while to figure this out and a hint like this would have speed things up for us a lot.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6138#discussion_r2173116294">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIO7AZ72B4HUEKEVC33FYJ4XAVCNFSM6AAAAACAJJKZ6OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRYGM2TKMJQGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMDF5YAVAK4A46DIVD3FYJ4XA5CNFSM6AAAAACAJJKZ6OWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVQ5WASA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6138/review/2968355104</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6138#discussion_r2173116294",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6138#discussion_r2173116294",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>