<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/4158490?s=20&v=4" /><strong>AntonKhorev</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-3013398792">(openstreetmap/openstreetmap-website#3715)</a></div>
<p dir="auto">I decided to address this completely:</p>
<blockquote>
<p dir="auto">Possibly it would better to add new tests rather than add lots of cases to the existing ones. I suspect <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> will think so though he'd probably also say we should split the existing one.</p>
</blockquote>
<p dir="auto">and split all <code class="notranslate">index</code> action tests, exisitng and added in this PR. Then I discovered that I never checked if old versions of elements were redacted. Added a fix for that too.</p>
<p dir="auto">The expected behavior if one of the requested versions is redacted wasn't documented anywhere, so I copied what cgimap did, which is 404 like for missing versions and missing elements.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-3013398792">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLFZPEM5IBNERAGRY33FVM2XAVCNFSM6AAAAABP72HKA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJTGM4TQNZZGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOEBZMATKJIDDT7D4D3FVM2XA5CNFSM6AAAAABP72HKA2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVTTTIQQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/3715/c3013398792</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-3013398792",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-3013398792",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>