<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2173785695">app/assets/javascripts/index/element.js</a>:</p>
<pre style='color:#555'>> + $("<img>")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" + data.icon, height: "32" })
+ .addClass("float-end mb-1 ms-2")
+ .appendTo(cell);
</pre>
<p dir="auto">In case anyone asks for an image attribution, we can have it linked to its Commons page.</p>
⬇️ Suggested change
<pre style="color: #555">- $("<img>")
- .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" + data.icon, height: "32" })
- .addClass("float-end mb-1 ms-2")
- .appendTo(cell);
+ $("<a>")
+ .attr({ href: OSM.WIKIMEDIA_COMMONS_URL + "File:" + data.icon })
+ .append(
+ $("<img>")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" + data.icon, height: "32" }))
+ .addClass("float-end mb-1 ms-2")
+ .appendTo(cell);
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2969284694">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL2LT7BDJUOJNFHOX33F74QRAVCNFSM6AAAAAB75WISWSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRZGI4DINRZGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKNRBUE6AY4EYZVQ6T3F74QRA5CNFSM6AAAAAB75WISWSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVQ7OYFM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6127/review/2969284694</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2969284694",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2969284694",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>