<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6127#discussion_r2175112102">app/assets/javascripts/index/element.js</a>:</p>
<pre style='color:#555'>> + $("#sidebar-content").on("turbo:before-stream-render", event => {
+ const defaultRender = event.detail.render;
+ event.detail.render = function (streamElement) {
+ defaultRender(streamElement);
+ markWikidataLinksAsExplainable();
+ };
+ });
</pre>
<p dir="auto">I was going to suggest another modification later after this PR is merged. The Q-links work differently depending on their state, they either open a wikidata page or add a row to the tags table. The state is invisible to the user, and this is not the most intuitive behaviour. So I was going to suggest to keep the Q-links working as before and have a button, likely with the wikidata logo, that adds a wikidata row to tags. The button could be placed where we have a color icon:</p>
<p dir="auto"><a href="https://github.com/user-attachments/assets/6c5efde9-eff6-482e-9e00-f2dc8d2d69a7">image.png (view on web)</a></p>
<p dir="auto">But looking at the code here, maybe it's easier to do this right away. We can have wikidata buttons rendered server-side with delegated click listeners. Then listening to turbo events that look for new Q-links won't be necessary.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2971286305">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJEA7LIUZGS2G4IQL33GE47BAVCNFSM6AAAAAB75WISWSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNZRGI4DMMZQGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLORH5W5EUJDHRSLVUD3GE47BA5CNFSM6AAAAAB75WISWSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVRDI5SC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6127/review/2971286305</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2971286305",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2971286305",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>