<p></p>
<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5706#discussion_r2185913060">test/controllers/accounts/terms_controller_test.rb</a>:</p>
<pre style='color:#555'>> +      session_for(user)
+
+      freeze_time do
+        put account_terms_path, :params => { :referer => "/test", :read_ct => 1, :read_tou => 1 }
+
+        assert_redirected_to "/test"
+        assert_equal "Thanks for accepting the new contributor terms!", flash[:notice]
+
+        user.reload
+        assert user.terms_seen
+        assert_equal Time.now.utc, user.terms_agreed
+        assert_equal Time.now.utc, user.tou_agreed
+      end
+    end
+
+    def test_update_previously_accepted
</pre>
<p dir="auto">We should probably have <code class="notranslate">test_decline_previously_accepted</code> to check that the dates don't change if you decline when revisiting the terms.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5706#pullrequestreview-2988059205">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKPI2DV7RMQBMZ22UT3G3BH3AVCNFSM6AAAAABXNHXYU2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOBYGA2TSMRQGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIWKMP2T4KSBUDBM5L3G3BH3A5CNFSM6AAAAABXNHXYU2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVSDIVEK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5706/review/2988059205</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5706#pullrequestreview-2988059205",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5706#pullrequestreview-2988059205",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>