<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/147741?s=20&v=4" /><strong>tomhughes</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-3065647432">(openstreetmap/openstreetmap-website#5880)</a></div>
<p dir="auto">I've read through all the comments on this issue and also had a look at <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a>'s work in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3002805520" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5938" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5938/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5938">#5938</a> and on the whole I think that I have to agree with <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/gravitystorm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/gravitystorm">@gravitystorm</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a> that it would better if we could keep the SVGs separate.</p>
<p dir="auto">I don't actually think that your position on whether SVGs should be hand written or created with a visual editor really alters the position on that - it's just generally easier for everybody if you can at least view what an image looks like in an image viewer or rich diff tool and combining languages in one file always makes life it's just that sometimes the benefits make it worthwhile but I'm not sure that's true here.</p>
<p dir="auto">Incidentally for a while I was unable to review edits to at least one of our view in <code class="notranslate">meld</code> because it would just bomb out and eventually I realised it was because it thought it was an SVG file and was trying to do a visual diff on it so I had to hack meld to disable that.</p>
<p dir="auto">I think <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a>'s work in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3002805520" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5938" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5938/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/5938">#5938</a> is generally good though I haven't done a detailed review but I think <a href="https://github.com/jamesmartin/inline_svg">https://github.com/jamesmartin/inline_svg</a> that he mentioned here might offer some advantages and I think a custom transform could do the magenta -> currentColor transformation but by actually parsing the XML instead of doing regexp edits on it which is always risky.</p>
<p dir="auto">It also provides caching of transformed SVGs and access to the rest of the asset pipeline like <code class="notranslate">svgo</code> optimisation.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-3065647432">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKVIKGUKEJB5QBKX3D3IEQNLAVCNFSM6AAAAAB2KIRQGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRVGY2DONBTGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNNKFDM2UKYY7GARYT3IEQNLA5CNFSM6AAAAAB2KIRQGKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVWXIIUQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/issues/5880/3065647432</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-3065647432",
"url": "https://github.com/openstreetmap/openstreetmap-website/issues/5880#issuecomment-3065647432",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>