<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6137#discussion_r2203291505">app/assets/javascripts/leaflet.map.js</a>:</p>
<pre style='color:#555'>>  L.extend(L.LatLngBounds.prototype, {
   getSize: function () {
     return (this._northEast.lat - this._southWest.lat) *
            (this._northEast.lng - this._southWest.lng);
   }
 });
 
+if (OSM.SHORTBREAD_STYLE_URL) {
</pre>
<p dir="auto">The problem with making this conditional is that if there is no URL configured the class won't be defined but <code class="notranslate">layers.yml</code> will still reference the layer and hence we will try and use the class.</p>
<p dir="auto">We either need to say the URL is mandatory, or we extend the layer definitions to allow the layer to be skipped.</p>

<hr>

<p>On <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6137#discussion_r2203290250">app/assets/javascripts/leaflet.map.js</a>:</p>
<p dir="auto">I think I would suggest actually creating two new files - a <code class="notranslate">leaflet.maplibregl.js</code> that does the maplibre requires and global configuration (basically just configuring the RTL plugin) and <code class="notranslate"> leaflet.shortbread.js</code> or something that requires <code class="notranslate">leaflet.maplibregl.js</code> and then defines the layer class.</p>
<p dir="auto">That file should then be included in <code class="notranslate">application.js</code> alongside <code class="notranslate">leaflet.osm</code> that defines the other layers.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6137#pullrequestreview-3014051764">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMMHAMPUQDE54CBNQ33IIWRPAVCNFSM6AAAAACAH65HMWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJUGA2TCNZWGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNCWG46CAJCVKFGOUD3IIWRPA5CNFSM6AAAAACAH65HMWWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVTU3D3I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6137/review/3014051764</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6137#pullrequestreview-3014051764",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6137#pullrequestreview-3014051764",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>