<p></p>
<p><b>@k-yle</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2206938166">config/initializers/tag2link.rb</a>:</p>
<pre style='color:#555'>> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/index.json").read)
+
+ ranks = %w[deprecated normal preferred].freeze
+
+ output = {}
+
+ all_keys = array.map { |item| item["key"] }.uniq
+
+ all_keys.each do |key|
+ # for each key, find the item with the best rank
+ best_definition = array
+ .select { |item| item["key"] == key }
+ .max_by { |item| ranks.index(item["rank"]) }
</pre>
<details>
<summary>This problem seems to only affect 17 tags, most of which are quite obscure (click to expand)</summary>
<div class="highlight highlight-source-python" dir="auto"><pre class="notranslate"><span class="pl-s1">de</span>:<span class="pl-smi">amtlicher_gemeindeschluessel</span> <span class="pl-c1">=</span> <span class="pl-c1">7</span>
<span class="pl-s1">fhrs</span>:<span class="pl-smi">id</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span>
<span class="pl-s1">hashtags</span> <span class="pl-c1">=</span> <span class="pl-c1">42</span>
<span class="pl-s1">icao</span> <span class="pl-c1">=</span> <span class="pl-c1">8</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">EU</span>:<span class="pl-smi">bwid</span> <span class="pl-c1">=</span> <span class="pl-c1">4</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">FR</span>:<span class="pl-smi">MemorialGenWeb</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">FR</span>:<span class="pl-smi">museofile</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">FR</span>:<span class="pl-smi">SIREN</span> <span class="pl-c1">=</span> <span class="pl-c1">5</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">ibnr</span> <span class="pl-c1">=</span> <span class="pl-c1">11</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">INEP</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">INSEE</span> <span class="pl-c1">=</span> <span class="pl-c1">4</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">ruian</span> <span class="pl-c1">=</span> <span class="pl-c1">3</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">vatin</span> <span class="pl-c1">=</span> <span class="pl-c1">4</span>
<span class="pl-s1">ref</span>:<span class="pl-smi">WDPA</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span>
<span class="pl-c1">*</span>:<span class="pl-s1">mmsi</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span>
<span class="pl-s1">uic_ref</span> <span class="pl-c1">=</span> <span class="pl-c1">6</span>
<span class="pl-s1">woeid</span> <span class="pl-c1">=</span> <span class="pl-c1">2</span></pre></div>
</details>
<p dir="auto">Maybe we should skip these ones if there are multiple matches with equal probability? If someone complains, then perhaps they should fix the problem upstream</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2206938166">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLII7NZIFZYTBRGXBBT3ITA3NAVCNFSM6AAAAACBRIR2AKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJZGQ3DOMRTGE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPMMDOEYL74JJVSZHD3ITA3NA5CNFSM6AAAAACBRIR2AKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVT7FU56.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6197/review/3019467231</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2206938166",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2206938166",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>