<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/5842757?s=20&v=4" /><strong>mmd-osm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3074886052">(openstreetmap/openstreetmap-website#6192)</a></div>
<p dir="auto">So the button is set to disabled in the setTimeout function below.</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-s1">$document</span><span class="pl-kos">.</span><span class="pl-en">on</span><span class="pl-kos">(</span><span class="pl-s">'submit.rails'</span><span class="pl-kos">,</span> <span class="pl-s1">rails</span><span class="pl-kos">.</span><span class="pl-c1">formSubmitSelector</span><span class="pl-kos">,</span> <span class="pl-k">function</span><span class="pl-kos">(</span><span class="pl-s1">e</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-k">var</span> <span class="pl-s1">form</span> <span class="pl-c1">=</span> <span class="pl-en">$</span><span class="pl-kos">(</span><span class="pl-smi">this</span><span class="pl-kos">)</span><span class="pl-kos">,</span>
<span class="pl-s1">remote</span> <span class="pl-c1">=</span> <span class="pl-s1">rails</span><span class="pl-kos">.</span><span class="pl-en">isRemote</span><span class="pl-kos">(</span><span class="pl-s1">form</span><span class="pl-kos">)</span><span class="pl-kos">,</span>
<span class="pl-s1">blankRequiredInputs</span><span class="pl-kos">,</span>
<span class="pl-s1">nonBlankFileInputs</span><span class="pl-kos">;</span>
<span class="pl-kos">[</span>...<span class="pl-kos">]</span>
<span class="pl-kos">}</span> <span class="pl-s1">else</span> <span class="pl-kos">{</span>
<span class="pl-c">// Slight timeout so that the submit button gets properly serialized</span>
<span class="pl-en">setTimeout</span><span class="pl-kos">(</span><span class="pl-k">function</span><span class="pl-kos">(</span><span class="pl-kos">)</span><span class="pl-kos">{</span> <span class="pl-s1">rails</span><span class="pl-kos">.</span><span class="pl-en">disableFormElements</span><span class="pl-kos">(</span><span class="pl-s1">form</span><span class="pl-kos">)</span><span class="pl-kos">;</span> <span class="pl-kos">}</span><span class="pl-kos">,</span> <span class="pl-c1">13</span><span class="pl-kos">)</span><span class="pl-kos">;</span> <span class="pl-c">// <<<<<</span>
<span class="pl-kos">}</span>
<span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p dir="auto">Re-enabling the button would work, if we were to use ajax:</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-s1">$document</span><span class="pl-kos">.</span><span class="pl-en">on</span><span class="pl-kos">(</span><span class="pl-s">'ajax:complete.rails'</span><span class="pl-kos">,</span> <span class="pl-s1">rails</span><span class="pl-kos">.</span><span class="pl-c1">formSubmitSelector</span><span class="pl-kos">,</span> <span class="pl-k">function</span><span class="pl-kos">(</span><span class="pl-s1">event</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-smi">this</span> <span class="pl-c1">===</span> <span class="pl-s1">event</span><span class="pl-kos">.</span><span class="pl-c1">target</span><span class="pl-kos">)</span> <span class="pl-s1">rails</span><span class="pl-kos">.</span><span class="pl-en">enableFormElements</span><span class="pl-kos">(</span><span class="pl-en">$</span><span class="pl-kos">(</span><span class="pl-smi">this</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span> </pre></div>
<p dir="auto">However, in this scenario, it's a plain HTTP POST, followed by a 302 response and another HTTP GET on render.openstreetmap.org.</p>
<p dir="auto">This event simply never fires, because it's not a "remote" call. The source code mentions a "data-remote" attribute to send the request as AJAX.</p>
<p dir="auto">However, CSP doesn't allow render.openstreetmap.org, the render site isn't properly handling CORS preflight requests, and the required totp cookie would be lost as well.</p>
<p dir="auto">Long story short, I don't see much alternatives at the moment to implement this.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3074886052">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOV3QPRHYOR6QIMN7L3IVBCDAVCNFSM6AAAAACBNKWLDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZUHA4DMMBVGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNFKWJAJJGTY5EIEK33IVBCDA5CNFSM6AAAAACBNKWLDGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVXI4E2I.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6192/c3074886052</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3074886052",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3074886052",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>