<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2208881812">config/initializers/tag2link.rb</a>:</p>
<pre style='color:#555'>> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/index.json").read)
+
+ ranks = %w[deprecated normal preferred].freeze
+
+ output = {}
+
+ all_keys = array.map { |item| item["key"] }.uniq
+
+ all_keys.each do |key|
+ # for each key, find the item with the best rank
+ best_definition = array
+ .select { |item| item["key"] == key }
+ .max_by { |item| ranks.index(item["rank"]) }
</pre>
<p dir="auto">Well that's what I thought <code class="notranslate">preferred</code> was, as against <code class="notranslate">normal</code>, but in seems in some cases there is more than one that is <code class="notranslate">preferred</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2208881812">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKPGIJFY2I4EDC6XA33IWEA5AVCNFSM6AAAAACBRIR2AKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMRSGU4TMNRUGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPGSLBKXRPW7EYOLI33IWEA5A5CNFSM6AAAAACBRIR2AKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVUFEVCK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6197/review/3022596645</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2208881812",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2208881812",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>