<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2210907793">config/initializers/tag2link.rb</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,25 @@
+# A map of each OSM key to its formatter URL. For example:
+# { "ref:vatin" => "https://example.com/$1" }
+TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient for lookups.
</pre>
<p dir="auto">Why do we need an immediately invoked lambda here? Just to avoid namespace pollution? You could actually write it all with only one variable other than the end result:</p>
<div class="highlight highlight-source-ruby" dir="auto"><pre class="notranslate"><span class="pl-c1">TAG2LINK</span> <span class="pl-c1">=</span> <span class="pl-c1">JSON</span><span class="pl-kos">.</span><span class="pl-en">parse</span><span class="pl-kos">(</span><span class="pl-v">Rails</span><span class="pl-kos">.</span><span class="pl-en">root</span><span class="pl-kos">.</span><span class="pl-en">join</span><span class="pl-kos">(</span><span class="pl-s">"node_modules/tag2link/index.json"</span><span class="pl-kos">)</span><span class="pl-kos">.</span><span class="pl-en">read</span><span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">reject</span> <span class="pl-kos">{</span> |<span class="pl-s1">item</span>| <span class="pl-s1">item</span><span class="pl-kos">[</span><span class="pl-s">"rank"</span><span class="pl-kos">]</span> == <span class="pl-s">"deprecated"</span> <span class="pl-kos">}</span>
<span class="pl-kos">.</span><span class="pl-en">group_by</span> <span class="pl-kos">{</span> |<span class="pl-s1">item</span>| <span class="pl-s1">item</span><span class="pl-kos">[</span><span class="pl-s">"key"</span><span class="pl-kos">]</span> <span class="pl-kos">}</span>
<span class="pl-kos">.</span><span class="pl-en">transform_keys</span> <span class="pl-kos">{</span> |<span class="pl-s1">key</span>| <span class="pl-s1">key</span><span class="pl-kos">.</span><span class="pl-en">sub</span><span class="pl-kos">(</span><span class="pl-sr">/^Key:/</span><span class="pl-kos">,</span> <span class="pl-s">""</span><span class="pl-kos">)</span> <span class="pl-kos">}</span>
<span class="pl-kos">.</span><span class="pl-en">transform_values</span> <span class="pl-kos">{</span> |<span class="pl-s1">items</span>| <span class="pl-s1">items</span><span class="pl-kos">.</span><span class="pl-en">max_by</span> <span class="pl-kos">{</span> |<span class="pl-s1">item</span>| <span class="pl-en">ranks</span><span class="pl-kos">.</span><span class="pl-en">index</span><span class="pl-kos">(</span><span class="pl-s1">item</span><span class="pl-kos">[</span><span class="pl-s">"rank"</span><span class="pl-kos">]</span><span class="pl-kos">)</span> <span class="pl-kos">}</span><span class="pl-kos">.</span><span class="pl-en">fetch</span><span class="pl-kos">(</span><span class="pl-s">"url"</span><span class="pl-kos">)</span> <span class="pl-kos">}</span></pre></div>
<p dir="auto">which just needs the array of ranks...</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#pullrequestreview-3025807777">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLP45BNKLIDPBY2I4S33IZ6QRAVCNFSM6AAAAACBRIR2AKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMRVHAYDONZXG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLO7KOBQKRVQHV37R4D3IZ6QRA5CNFSM6AAAAACBRIR2AKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVULIU2C.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6197/review/3025807777</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#pullrequestreview-3025807777",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#pullrequestreview-3025807777",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>