<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2216313135">config/initializers/marker_colors.rb</a>:</p>
<pre style='color:#555'>> +MARKER_COLORS = {
+ :red => "#f6110a",
+ :green => "#9cef11",
+ :blue => "#0b8ef1"
+}.freeze
</pre>
<p dir="auto">Why not css properties? That's where I'd expect to find color definitions.</p>
<p dir="auto">You can put something like this in <code class="notranslate">common.scss</code>:</p>
<div class="highlight highlight-source-css" dir="auto"><pre class="notranslate"><span class="pl-kos">:</span><span class="pl-c1">root</span> {
<span class="pl-s1">--marker-red</span><span class="pl-kos">:</span> <span class="pl-pds"><span class="pl-kos">#</span>f6110a</span>;
<span class="pl-s1">--marker-green</span><span class="pl-kos">:</span> <span class="pl-pds"><span class="pl-kos">#</span>9cef11</span>;
<span class="pl-s1">--marker-blue</span><span class="pl-kos">:</span> <span class="pl-pds"><span class="pl-kos">#</span>0b8ef1</span>;
}</pre></div>
<p dir="auto">Then you can reference them like this: <code class="notranslate">color="var(--marker-green)"</code>.</p>
<p dir="auto">You won't need an initializer, and you probably won't need embed anything into js like <code class="notranslate"><%= MARKER_COLORS.to_json %></code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-3033939316">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJVVUGQSUGIYUPMJ2D3JEFSPAVCNFSM6AAAAABZ4WJVUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZTHEZTSMZRGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLRUYGLL6QKJ2OQ7LL3JEFSPA5CNFSM6AAAAABZ4WJVUSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVU2Y6XI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5854/review/3033939316</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-3033939316",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-3033939316",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>