<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2215744334">app/views/layouts/_search.html.erb</a>:</p>
<pre style='color:#555'>> + <svg viewBox="0 0 25 40" class="img-fluid" data-type="from" draggable="true">
+ <use href="#pin-dot" color="<%= MARKER_COLORS[:green] %>" />
+ </svg>
</pre>
<p dir="auto">Changes I had to make to keep drag events working (1/3):</p>
⬇️ Suggested change
<pre style="color: #555">- <svg viewBox="0 0 25 40" class="img-fluid" data-type="from" draggable="true">
- <use href="#pin-dot" color="<%= MARKER_COLORS[:green] %>" />
- </svg>
+ <span draggable="true" data-type="from">
+ <svg viewBox="0 0 25 40" class="img-fluid" draggable="true">
+ <use href="#pin-dot" color="<%= MARKER_COLORS[:green] %>" />
+ </svg>
+ </span>
</pre>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2215746458">app/views/layouts/_search.html.erb</a>:</p>
<pre style='color:#555'>> + <svg viewBox="0 0 25 40" class="img-fluid" data-type="to" draggable="true">
+ <use href="#pin-dot" color="<%= MARKER_COLORS[:red] %>" />
+ </svg>
</pre>
<p dir="auto">Changes I had to make to keep drag events working (2/3):</p>
⬇️ Suggested change
<pre style="color: #555">- <svg viewBox="0 0 25 40" class="img-fluid" data-type="to" draggable="true">
- <use href="#pin-dot" color="<%= MARKER_COLORS[:red] %>" />
- </svg>
+ <span draggable="true" data-type="to">
+ <svg viewBox="0 0 25 40" class="img-fluid" draggable="true">
+ <use href="#pin-dot" color="<%= MARKER_COLORS[:red] %>" />
+ </svg>
+ </span>
</pre>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2215749717">app/assets/javascripts/index/directions.js</a>:</p>
<pre style='color:#555'>> - $(".routing_marker_column img").on("dragstart", function (e) {
+ $(".routing_marker_column svg").on("dragstart", function (e) {
const dt = e.originalEvent.dataTransfer;
dt.effectAllowed = "move";
- const dragData = { type: $(this).data("type") };
- dt.setData("text", JSON.stringify(dragData));
+ const jqthis = $(this);
+ dt.setData("text", JSON.stringify(jqthis.data()));
if (dt.setDragImage) {
- const img = $("<img>").attr("src", $(e.originalEvent.target).attr("src"));
+ const img = jqthis.clone()
+ .toggleClass("img-fluid position-absolute bottom-100 end-100")
+ .attr({ width: "25", height: "40" })
+ .appendTo(document.body);
dt.setDragImage(img.get(0), 12, 21);
+ setTimeout(() => img.remove(), 0);
}
});
</pre>
<p dir="auto">Changes I had to make to keep drag events working (3/3):</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"> <span class="pl-en">$</span><span class="pl-kos">(</span><span class="pl-s">".routing_marker_column > span"</span><span class="pl-kos">)</span><span class="pl-kos">.</span><span class="pl-en">on</span><span class="pl-kos">(</span><span class="pl-s">"dragstart"</span><span class="pl-kos">,</span> <span class="pl-k">function</span> <span class="pl-kos">(</span><span class="pl-s1">e</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-k">const</span> <span class="pl-s1">dt</span> <span class="pl-c1">=</span> <span class="pl-s1">e</span><span class="pl-kos">.</span><span class="pl-c1">originalEvent</span><span class="pl-kos">.</span><span class="pl-c1">dataTransfer</span><span class="pl-kos">;</span>
<span class="pl-s1">dt</span><span class="pl-kos">.</span><span class="pl-c1">effectAllowed</span> <span class="pl-c1">=</span> <span class="pl-s">"move"</span><span class="pl-kos">;</span>
<span class="pl-k">const</span> <span class="pl-s1">jqthis</span> <span class="pl-c1">=</span> <span class="pl-en">$</span><span class="pl-kos">(</span><span class="pl-smi">this</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">dt</span><span class="pl-kos">.</span><span class="pl-en">setData</span><span class="pl-kos">(</span><span class="pl-s">"text"</span><span class="pl-kos">,</span> <span class="pl-c1">JSON</span><span class="pl-kos">.</span><span class="pl-en">stringify</span><span class="pl-kos">(</span><span class="pl-s1">jqthis</span><span class="pl-kos">.</span><span class="pl-en">data</span><span class="pl-kos">(</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-s1">dt</span><span class="pl-kos">.</span><span class="pl-c1">setDragImage</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
<span class="pl-k">const</span> <span class="pl-s1">img</span> <span class="pl-c1">=</span> <span class="pl-s1">jqthis</span><span class="pl-kos">.</span><span class="pl-en">clone</span><span class="pl-kos">(</span><span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">appendTo</span><span class="pl-kos">(</span><span class="pl-smi">document</span><span class="pl-kos">.</span><span class="pl-c1">body</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">img</span><span class="pl-kos">.</span><span class="pl-en">find</span><span class="pl-kos">(</span><span class="pl-s">"svg"</span><span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">toggleClass</span><span class="pl-kos">(</span><span class="pl-s">"img-fluid position-absolute bottom-100 end-100"</span><span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">attr</span><span class="pl-kos">(</span><span class="pl-kos">{</span> <span class="pl-c1">width</span>: <span class="pl-s">"25"</span><span class="pl-kos">,</span> <span class="pl-c1">height</span>: <span class="pl-s">"40"</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-s1">dt</span><span class="pl-kos">.</span><span class="pl-en">setDragImage</span><span class="pl-kos">(</span><span class="pl-s1">img</span><span class="pl-kos">.</span><span class="pl-en">get</span><span class="pl-kos">(</span><span class="pl-c1">0</span><span class="pl-kos">)</span><span class="pl-kos">,</span> <span class="pl-c1">12</span><span class="pl-kos">,</span> <span class="pl-c1">21</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-en">setTimeout</span><span class="pl-kos">(</span><span class="pl-kos">(</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-s1">img</span><span class="pl-kos">.</span><span class="pl-en">remove</span><span class="pl-kos">(</span><span class="pl-kos">)</span><span class="pl-kos">,</span> <span class="pl-c1">0</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span>
<span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-3033107404">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOHEO4KE2NN3EIXBB33JDHDPAVCNFSM6AAAAABZ4WJVUSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZTGEYDONBQGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP7HCA6UKGPT4OGEV33JDHDPA5CNFSM6AAAAABZ4WJVUSWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVUZGF4Y.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/5854/review/3033107404</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-3033107404",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-3033107404",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>