<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/5842757?s=20&v=4" /><strong>mmd-osm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094256517">(openstreetmap/openstreetmap-website#6192)</a></div>
<p dir="auto">Currently the export script returns errors as text/html, which Turbo happily picks up to replace the osm.org page. In this case, the user has to reload the page. Browser back button would take them to a random place, which is quite annoying.</p>
<p dir="auto">Maybe it's better for the export script to return error messages as plain text. Turbo ignores this response, we can display the alert popup and nothing else happens.</p>
<p dir="auto">As an alternative, <a href="https://discuss.hotwired.dev/t/finally-understanding-turbo-stream/1964/8" rel="nofollow">https://discuss.hotwired.dev/t/finally-understanding-turbo-stream/1964/8</a> talks about some funny stuff we could do with Turbo Streams, though it seems a bit over-engineered for this use case.</p>
<p dir="auto">leaflet.share.js:</p>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate">      <span class="pl-kos">}</span> <span class="pl-k">else</span> <span class="pl-kos">{</span>
        <span class="pl-k">let</span> <span class="pl-s1">detailMessage</span><span class="pl-kos">;</span>
        <span class="pl-k">try</span> <span class="pl-kos">{</span>
          <span class="pl-s1">detailMessage</span> <span class="pl-c1">=</span> <span class="pl-s1">event</span><span class="pl-kos">?.</span><span class="pl-c1">detail</span><span class="pl-kos">?.</span><span class="pl-c1">error</span><span class="pl-kos">?.</span><span class="pl-c1">message</span><span class="pl-kos">;</span>
          <span class="pl-k">if</span> <span class="pl-kos">(</span><span class="pl-c1">!</span><span class="pl-s1">detailMessage</span><span class="pl-kos">)</span> <span class="pl-kos">{</span>
            <span class="pl-s1">detailMessage</span> <span class="pl-c1">=</span> <span class="pl-k">await</span> <span class="pl-s1">event</span><span class="pl-kos">.</span><span class="pl-c1">detail</span><span class="pl-kos">.</span><span class="pl-c1">fetchResponse</span><span class="pl-kos">.</span><span class="pl-c1">responseText</span><span class="pl-kos">;</span>
          <span class="pl-kos">}</span>
        <span class="pl-kos">}</span> <span class="pl-k">catch</span> <span class="pl-kos">{</span>
          <span class="pl-s1">detailMessage</span> <span class="pl-c1">=</span> <span class="pl-s">"(unknown)"</span><span class="pl-kos">;</span>
        <span class="pl-kos">}</span>
        <span class="pl-c">// eslint-disable-next-line no-alert</span>
        <span class="pl-en">alert</span><span class="pl-kos">(</span><span class="pl-c1">OSM</span><span class="pl-kos">.</span><span class="pl-c1">i18n</span><span class="pl-kos">.</span><span class="pl-en">t</span><span class="pl-kos">(</span><span class="pl-s">"javascripts.share.export_failed"</span><span class="pl-kos">,</span> <span class="pl-kos">{</span> <span class="pl-c1">reason</span>: <span class="pl-s1">detailMessage</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
      <span class="pl-kos">}</span></pre></div>
<p dir="auto">export.erb:</p>
<div class="highlight highlight-source-python" dir="auto"><pre class="notranslate"><span class="pl-c"># Routine to report an error</span>
<span class="pl-k">def</span> <span class="pl-en">output_error</span>(<span class="pl-s1">message</span>, <span class="pl-s1">status</span> <span class="pl-c1">=</span> <span class="pl-s">"400 Bad Request"</span>):
  <span class="pl-en">print</span>(<span class="pl-s">"Status: %s"</span> <span class="pl-c1">%</span> <span class="pl-s1">status</span>)
  <span class="pl-en">output_headers</span>(<span class="pl-s">"text/plain"</span>)
  <span class="pl-en">print</span>(<span class="pl-s1">message</span>)</pre></div>
<p dir="auto">Result:</p>
<a href="https://github.com/user-attachments/assets/1b4c99b3-3cdd-4c3a-a1f9-b62ef035595d">image.png (view on web)</a>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094256517">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLN7Q77Q65B2GSFCGJ33JNFVNAVCNFSM6AAAAACBNKWLDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJUGI2TMNJRG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJ65GA6JEAKFKM7I333JNFVNA5CNFSM6AAAAACBNKWLDGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTVYN2NYK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6192/c3094256517</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094256517",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#issuecomment-3094256517",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>