<p></p>
<p><b>@k-yle</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2218556704">config/initializers/tag2link.rb</a>:</p>
<pre style='color:#555'>> +TAG2LINK = lambda {
+ # the JSON data is an array with duplicate entries, which is not efficient for lookups.
+ # So, convert it to a hash and only keep the item with the best rank.
+ array = JSON.parse(Rails.root.join("node_modules/tag2link/index.json").read)
+
+ ranks = %w[deprecated normal preferred].freeze
+
+ output = {}
+
+ all_keys = array.map { |item| item["key"] }.uniq
+
+ all_keys.each do |key|
+ # for each key, find the item with the best rank
+ best_definition = array
+ .select { |item| item["key"] == key }
+ .max_by { |item| ranks.index(item["rank"]) }
</pre>
<blockquote>
<p dir="auto">[...] in some cases there is more than one that is <code class="notranslate">preferred</code>.</p>
</blockquote>
<p dir="auto">Wikidata considers this an error:</p>
<a href="https://github.com/user-attachments/assets/64aeea5b-a287-4d51-95a9-200d78e5b13e">image.png (view on web)</a>
<p dir="auto">After exluding <a href="https://wikidata.org/wiki/Property:P3303" rel="nofollow"><code class="notranslate">wikidata:P3303</code></a> and cleaning up a few cases where the only difference was <code class="notranslate">www.</code> or <code class="notranslate">http[s]</code>, there are only 4 left which are ambiguous:</p>
<p dir="auto"><code class="notranslate">de:amtlicher_gemeindeschluessel</code>, <code class="notranslate">ref:INEP</code>, <code class="notranslate">ref:ruian</code>, <code class="notranslate">woeid</code></p>
<p dir="auto">So... I think we just exclude any keys where there isn't a single-best URL.</p>
<details>
<summary>source</summary>
<div class="highlight highlight-source-js" dir="auto"><pre class="notranslate"><span class="pl-k">const</span> <span class="pl-kos">{</span> <span class="pl-c1">default</span>: <span class="pl-s1">uniqBy</span> <span class="pl-kos">}</span> <span class="pl-c1">=</span> <span class="pl-k">await</span> <span class="pl-k">import</span><span class="pl-kos">(</span><span class="pl-s">"https://esm.sh/lodash.uniqby"</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-k">const</span> <span class="pl-kos">{</span> <span class="pl-c1">default</span>: <span class="pl-s1">list</span> <span class="pl-kos">}</span> <span class="pl-c1">=</span> <span class="pl-k">await</span> <span class="pl-k">import</span><span class="pl-kos">(</span><span class="pl-s">"https://esm.sh/tag2link"</span><span class="pl-kos">)</span><span class="pl-kos">;</span>
<span class="pl-k">const</span> <span class="pl-c1">RANKS</span> <span class="pl-c1">=</span> <span class="pl-kos">[</span><span class="pl-s">"normal"</span><span class="pl-kos">,</span> <span class="pl-s">"preferred"</span><span class="pl-kos">]</span><span class="pl-kos">;</span>
<span class="pl-v">Object</span><span class="pl-kos">.</span><span class="pl-en">fromEntries</span><span class="pl-kos">(</span>
<span class="pl-v">Object</span><span class="pl-kos">.</span><span class="pl-en">values</span><span class="pl-kos">(</span>
<span class="pl-v">Object</span><span class="pl-kos">.</span><span class="pl-en">groupBy</span><span class="pl-kos">(</span>
<span class="pl-s1">list</span><span class="pl-kos">.</span><span class="pl-en">filter</span><span class="pl-kos">(</span>
<span class="pl-kos">(</span><span class="pl-s1">item</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-s1">item</span><span class="pl-kos">.</span><span class="pl-c1">rank</span> <span class="pl-c1">!==</span> <span class="pl-s">"deprecated"</span> <span class="pl-c1">&&</span> <span class="pl-s1">item</span><span class="pl-kos">.</span><span class="pl-c1">source</span> <span class="pl-c1">!==</span> <span class="pl-s">"wikidata:P3303"</span>
<span class="pl-kos">)</span><span class="pl-kos">,</span>
<span class="pl-kos">(</span><span class="pl-s1">item</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-s1">item</span><span class="pl-kos">.</span><span class="pl-c1">key</span>
<span class="pl-kos">)</span>
<span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">map</span><span class="pl-kos">(</span><span class="pl-kos">(</span><span class="pl-s1">sublist</span><span class="pl-kos">)</span> <span class="pl-c1">=></span>
<span class="pl-c">// remove items with the same URL and sort by rank</span>
<span class="pl-s1">uniqBy</span><span class="pl-kos">(</span>
<span class="pl-s1">sublist</span><span class="pl-kos">.</span><span class="pl-en">sort</span><span class="pl-kos">(</span><span class="pl-kos">(</span><span class="pl-s1">a</span><span class="pl-kos">,</span> <span class="pl-s1">b</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-c1">RANKS</span><span class="pl-kos">.</span><span class="pl-en">indexOf</span><span class="pl-kos">(</span><span class="pl-s1">b</span><span class="pl-kos">.</span><span class="pl-c1">rank</span><span class="pl-kos">)</span> <span class="pl-c1">-</span> <span class="pl-c1">RANKS</span><span class="pl-kos">.</span><span class="pl-en">indexOf</span><span class="pl-kos">(</span><span class="pl-s1">a</span><span class="pl-kos">.</span><span class="pl-c1">rank</span><span class="pl-kos">)</span><span class="pl-kos">)</span><span class="pl-kos">,</span>
<span class="pl-kos">(</span><span class="pl-s1">item</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-s1">item</span><span class="pl-kos">.</span><span class="pl-c1">url</span>
<span class="pl-kos">)</span>
<span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">filter</span><span class="pl-kos">(</span><span class="pl-kos">(</span><span class="pl-s1">sublist</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-kos">{</span>
<span class="pl-c">// keep only those where the best & second-best have the same rank</span>
<span class="pl-k">const</span> <span class="pl-kos">[</span><span class="pl-s1">best</span><span class="pl-kos">,</span> <span class="pl-s1">secondBest</span><span class="pl-kos">]</span> <span class="pl-c1">=</span> <span class="pl-s1">sublist</span><span class="pl-kos">;</span>
<span class="pl-k">return</span> <span class="pl-s1">best</span> <span class="pl-c1">&&</span> <span class="pl-s1">secondBest</span> <span class="pl-c1">&&</span> <span class="pl-s1">best</span><span class="pl-kos">.</span><span class="pl-c1">rank</span> <span class="pl-c1">==</span> <span class="pl-s1">secondBest</span><span class="pl-kos">.</span><span class="pl-c1">rank</span><span class="pl-kos">;</span>
<span class="pl-kos">}</span><span class="pl-kos">)</span>
<span class="pl-kos">.</span><span class="pl-en">map</span><span class="pl-kos">(</span><span class="pl-kos">(</span><span class="pl-s1">sublist</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-kos">[</span>
<span class="pl-c">// print the ones with the best rank</span>
<span class="pl-s1">sublist</span><span class="pl-kos">[</span><span class="pl-c1">0</span><span class="pl-kos">]</span><span class="pl-kos">.</span><span class="pl-c1">key</span><span class="pl-kos">,</span>
<span class="pl-s1">sublist</span><span class="pl-kos">.</span><span class="pl-en">filter</span><span class="pl-kos">(</span><span class="pl-kos">(</span><span class="pl-s1">item</span><span class="pl-kos">)</span> <span class="pl-c1">=></span> <span class="pl-s1">item</span><span class="pl-kos">.</span><span class="pl-c1">rank</span> <span class="pl-c1">===</span> <span class="pl-s1">sublist</span><span class="pl-kos">[</span><span class="pl-c1">0</span><span class="pl-kos">]</span><span class="pl-kos">.</span><span class="pl-c1">rank</span><span class="pl-kos">)</span><span class="pl-kos">,</span>
<span class="pl-kos">]</span><span class="pl-kos">)</span>
<span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div>
</details>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2218556704">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKKZ374EBDVYMOSEXL3JSSYBAVCNFSM6AAAAACBRIR2AKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZXGEYDGOJQGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMQMDREXJKSMHUJHCT3JSSYBA5CNFSM6AAAAACBRIR2AKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVVA2DSA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6197/review/3037103904</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2218556704",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6197#discussion_r2218556704",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>