<p dir="auto">I'm doing this also to check where it's best to store color definitions, see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2952570889" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5854" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5854/hovercard?comment_id=2216313135&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/5854#discussion_r2216313135">#5854 (comment)</a>. <code class="notranslate">parameters.scss</code> seems like a possible place because we already have some colors in it.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/6215'>https://github.com/openstreetmap/openstreetmap-website/pull/6215</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/commits/a2d48d6527867cc38d7e94f356e45b8c45d64ceb" class="commit-link">a2d48d6</a>  Replace role_icons helper with erb template</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/commits/051e61fea3c5561b354c41973d52015c8f9e7804" class="commit-link">051e61f</a>  Replaces role_icons helper with template code</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/commits/9ccfd3d1cbd4756c5c6a24aa61353327e9125bd5" class="commit-link">9ccfd3d</a>  Move role colors to css</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/commits/c55c6e1498b2dddda8617244753e4bc262ee852d" class="commit-link">c55c6e1</a>  Replace role_icon_svg_tag helper with inline_svg_tag</li>
  <li><a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/commits/46b89a820c91ed21873bc564d85cae624ee6c144" class="commit-link">46b89a8</a>  Gather together i18n strings of role icons</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files">10 files</a>)</p>
<ul>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-045cdb2e89ccd86052a89e5dc996550accecba78ea5363b08a593981baf39178">app/assets/images/icons/role-star-fill.svg</a>
    (3)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-d4f164452f52b85530b3e402f3d22990eddcaebf6bc5a5061bb6083af520146b">app/assets/images/icons/role-star.svg</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-d2e82deee467e04b34fde66bc330f96ed2020aefc541445c1d576a56612ee71b">app/assets/stylesheets/parameters.scss</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-fa5c6fa3fe725cd20fd8f42d8dc47d0719e073ceeb6947380102831498929f1a">app/assets/stylesheets/print.scss</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-d3d8591d9708bdc429ce04c584108c9b06c3ebea9f6ae56f11d6a05fecfe0f22">app/helpers/authorization_helper.rb</a>
    (3)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-cb3cde84283598fd23a737f6f9cee7574a44b2f6f0d9143176fa9cb1f3e2ec6a">app/helpers/user_roles_helper.rb</a>
    (42)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-3b5acbd834d883cd0181526f95d5e9b99c8d4f39bd1382b1367a9eda84d1a680">app/views/users/_role_icons.html.erb</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-78ff736409d758722403cce31873ba803b3fb526d37398ca21caa557b54dfd95">app/views/users/show.html.erb</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-44438ce218f5287c58d0017f965d888715635d94280669896f75841fbd7b4cd7">config/locales/en.yml</a>
    (31)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215/files#diff-ef464a99e1a54021faabde556fab78a493ad34d36bc5f823ea7b2d22581de520">test/helpers/user_roles_helper_test.rb</a>
    (172)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6215.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/6215.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/6215.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/6215.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6215">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIGQR2S6O3H66IYHS33JS3Q3AVCNFSM6AAAAACB7MDZJ6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGI2DOOJYGY3TCOI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJCFD6WX6POG7ME3H33JS3Q3A5CNFSM6AAAAACB7MDZJ6WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHMDGCYD4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6215</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6215",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6215",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>