<p></p>
<p><b>@petr-hajek</b> requested changes on this pull request.</p>
<p dir="auto">I think to avoid code repetition between maptiler and shortbread, best would be to move the logic to leaflet.maplibre.js</p>
<pre class="notranslate"><code class="notranslate">L.OSM.MaplibreMap = L.MaplibreGL.extend({
_getAttribution: function () {
return this.options.attribution;
},
_blankAttribution: function () {
return "";
},
onAdd: function (map) {
this.getAttribution = this._blankAttribution;
L.MaplibreGL.prototype.onAdd.call(this, map);
this.getAttribution = this._getAttribution;
}
});
</code></pre>
<p dir="auto">And then to extend this from both of the files</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6236#pullrequestreview-3049187522">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIA3XWYOQ4POVVBYET3J77Y3AVCNFSM6AAAAACCHB4HYCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANBZGE4DONJSGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLXFNPIGJFVSWZ6ETT3J77Y3A5CNFSM6AAAAACCHB4HYCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVVX3UME.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6236/review/3049187522</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6236#pullrequestreview-3049187522",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6236#pullrequestreview-3049187522",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>