<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229429352">app/assets/javascripts/leaflet.share.js</a>:</p>
<pre style='color:#555'>> +    $("#export-image").on("turbo:submit-end", async function (event) {
+      if (event.detail.success) {
+        await handleExportSuccess(event.detail.fetchResponse);
+      } else {
+        await handleExportError(event);
+      }
+    });
</pre>
<p dir="auto">I tested this version, and it seems to work. However, both handle* functions would still return a Promise which is resolved later. In the meantime, Turbo submit cleanup code continues to run. That's not so bad here as it resets UI element statuses mainly, and it's the very last event in this whole process.</p>
<p dir="auto">One thing I found a bit strange is that I see jquery-simulate as Event dispatcher, based on a jquery 1.7.2 version.</p>
<p dir="auto">That's function <code class="notranslate">dispatch</code> in the screenshot below, node_modules/jquery-simulate/external/jquery-1.7.2/jquery.js:3331</p>
<a href="https://github.com/user-attachments/assets/2d984a61-2a88-4a72-a6f6-31363e440298">image.png (view on web)</a>
<p dir="auto">I'm not so sure why I'm seeing this code outside of unit tests. It would be nicer to test Turbo without this intermediate jquery code.</p>
<p dir="auto">jquery-simulate describes itself as "Simulate events to help unit test user interactions.". Maybe it's used in a different way in this project?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229429352">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLHTOTLEJXFZMDL2ZT3KEZL3AVCNFSM6AAAAACBNKWLDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJTGA2TGNZZGA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKDBSPLCUZ4JMEJCNL3KEZL3A5CNFSM6AAAAACBNKWLDGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVV7HTV4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6192/review/3053053790</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229429352",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229429352",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>