<p></p>
<p><b>@mmd-osm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229478181">app/assets/javascripts/leaflet.share.js</a>:</p>
<pre style='color:#555'>> + $("#export-image").on("turbo:submit-end", async function (event) {
+ if (event.detail.success) {
+ await handleExportSuccess(event.detail.fetchResponse);
+ } else {
+ await handleExportError(event);
+ }
+ });
</pre>
<p dir="auto">I know this sounds a bit strange... with jquery-simulate in place, I have seen out of sequence calls to <code class="notranslate">this.delegate.formSubmissionFinished(this);</code> before our own <code class="notranslate">turbo:before-fetch-response</code> event handler has finished.</p>
<p dir="auto">Now, with jquiery-simulate uninstalled and the respective code in history.js removed, I don't see this out of sequence calls anymore. I tested each case on Firefox and Chrome with consistent behavior.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229478181">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKEXRTU4QRL7O2EAUT3KE4URAVCNFSM6AAAAACBNKWLDGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJTGEZDQNZTGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI2ZEEF4IKXZPBIRAL3KE4URA5CNFSM6AAAAACBNKWLDGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVV7MGB6.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6192/review/3053128735</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229478181",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6192#discussion_r2229478181",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>