<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6255#discussion_r2233907844">app/assets/javascripts/leaflet.share.js</a>:</p>
<pre style='color:#555'>> - document.body.appendChild(a);
- a.click();
- document.body.removeChild(a);
- URL.revokeObjectURL(url);
- }
-
- async function handleExportSuccess(fetchResponse) {
- try {
- const blob = await fetchResponse.response.blob();
- const filename = OSM.i18n.t("javascripts.share.filename");
- downloadBlob(blob, filename);
- } catch (err) {
- // eslint-disable-next-line no-alert
- alert(OSM.i18n.t("javascripts.share.export_failed", { reason: "(blob error)" }));
- }
- }
</pre>
<p dir="auto">Oh sorry, I was wanting to ask if we need two blank lines here. The previous didn't have two either, and this version is even shorter.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6255#discussion_r2233907844">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLILHLJR6ZN3D53LHXD3KSUUBAVCNFSM6AAAAACCNPOCDKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJZGQ3DCNJWGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLHMMSOKQFJPAAKRJD3KSUUBA5CNFSM6AAAAACCNPOCDKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVWLOW3Y.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6255/review/3059461564</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6255#discussion_r2233907844",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6255#discussion_r2233907844",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>