<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6235#discussion_r2233885965">app/assets/javascripts/index/search.js</a>:</p>
<pre style='color:#555'>>    }
 
   function showSearchResult() {
-    let marker = $(this).data("marker");
-
-    if (!marker) {
-      const data = $(this).find("a.set_position").data();
-
-      marker = L.marker([data.lat, data.lon], { icon: OSM.getMarker({}) });
-
-      $(this).data("marker", marker);
-    }
-
+    const index = processedResults++;
+    const listItem = $(this);
+    const color = `hwb(${(index * (Math.sqrt(5) - 1) * 180) % 360}deg 5% 5%)`;
</pre>
<p dir="auto">This actually appears to be the reciprocal of the golden angle (~222.5 degrees) not the golden angle (~137.5 degrees) at least according to <a href="https://en.wikipedia.org/wiki/Golden_angle" rel="nofollow">https://en.wikipedia.org/wiki/Golden_angle</a>?</p>
<p dir="auto">The golden angle would be:</p>
⬇️ Suggested change
<pre style="color: #555">-    const color = `hwb(${(index * (Math.sqrt(5) - 1) * 180) % 360}deg 5% 5%)`;
+    const color = `hwb(${(index * (3 - Math.sqrt(5) ) * 180) % 360}deg 5% 5%)`;
</pre>

<p dir="auto">Possibly that calculation should be pulled out to a <code class="notranslate">goldenAngle</code> variable that is then used in the template, as a way of documenting what we're doing?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6235#pullrequestreview-3059438187">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKHERLSW7B5DGMFB433KSMURAVCNFSM6AAAAACCGRKE46VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANJZGQZTQMJYG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLICBHNRZSH5G2VP2C33KSMURA5CNFSM6AAAAACCGRKE46WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVWLNJGW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6235/review/3059438187</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6235#pullrequestreview-3059438187",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6235#pullrequestreview-3059438187",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>