<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r2249999654">app/assets/javascripts/download_util.js</a>:</p>
<pre style='color:#555'>>    }
 
   OSM.getTurboBlobHandler = DownloadUtil.getTurboBlobHandler;
+  OSM.getHtmlResponseHandler = DownloadUtil.getHtmlResponseHandler;
</pre>
<p dir="auto">I was thinking much the same things when I looked at this, namely why are we defining things in a private class and them immediately exporting them to the global namespace, and why are we using an IIFE for things in the global namespace.</p>
<p dir="auto">I guess if the class remains private the <code class="notranslate">getTurboBlobHandler</code> at least would have to remain in the IIFE even if was moved outside the class as it needs to reference it.</p>
<p dir="auto">I don't think any of this is a show stopper in any case.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r2249999654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNVSSSALGDF37EAWMD3LYL3HAVCNFSM6AAAAACC7YBQQOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAOBSGIYDAOBZG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLI4CHV46DBDLBWGM5L3LYL3HA5CNFSM6AAAAACC7YBQQOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVXW2TUC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6284/review/3082200897</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r2249999654",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6284#discussion_r2249999654",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>