<p></p>
<p><b>@HolgerJeromin</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6304#discussion_r2264178908">app/assets/javascripts/numbered_pagination.js</a>:</p>
<pre style='color:#555'>> + $(document).on("numbered_pagination:enable", function () {
+ shadowEffect = new ShadowEffect();
+ $(document).trigger("numbered_pagination:center");
+ });
+
+ $(document).on("numbered_pagination:disable", function () {
+ shadowEffect?.disable();
+ shadowEffect = null;
+ });
+
+ $(document).on("numbered_pagination:center", function () {
+ const [scrollableList] = $("#versions-navigation-list-middle");
+
+ if (!scrollableList) return;
+
+ const [activeStartItem] = $("#versions-navigation-list-start #versions-navigation-active-page-item");
</pre>
<p dir="auto">As you are working on a DOM element (and not jquery collections) I would go with this</p>
⬇️ Suggested change
<pre style="color: #555">- const [activeStartItem] = $("#versions-navigation-list-start #versions-navigation-active-page-item");
+ const activeStartItem = document.querySelector("#versions-navigation-list-start #versions-navigation-active-page-item");
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6304#pullrequestreview-3102368086">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJFU6KDYZJTA6ENU3D3MVEA7AVCNFSM6AAAAACDORWVUKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMBSGM3DQMBYGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMTP6HBPFGQ5AJ3VGD3MVEA7A5CNFSM6AAAAACDORWVUKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVY5JQVM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6304/review/3102368086</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6304#pullrequestreview-3102368086",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6304#pullrequestreview-3102368086",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>