<p></p>
<p><b>@1ec5</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6313#discussion_r2268795262">config/ui_languages.yml</a>:</p>
<pre style='color:#555'>>  - :code: zh-CN
   :native_name: 中文（简体）
+  :english_name: Chinese (Simplified)
 - :code: zh-TW
   :native_name: 中文（繁體）
+  :english_name: Chinese (Traditional)
 - :code: zh-HK
   :native_name: 中文（香港）
+  :english_name: Chinese (Hong Kong)
</pre>
<p dir="auto">It’s unusual to have a choice between “Traditional” and “Hong Kong”. I guess Chinese speakers will infer that the “Traditional” option is Taiwanese, but it’s kind of awkward.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6313#discussion_r2268803424">app/views/layouts/_select_language_list.html.erb</a>:</p>
<pre style='color:#555'>> +        <small lang="en" class="english_name d-block text-secondary">
+          <%= language[:english_name] %>
+        </small>
</pre>
<p dir="auto">Are we hard-coding English only because most fonts support it, or are there other reasons? Translated language names would be useful to users who want to see the map in a language other than their own, but in that case, we should try to localize the language name into the current language, falling back to English. I think we can assume that the user has an adequate font for the language they currently prefer.</p>
<p dir="auto">/ref <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2522104850" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/5201" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/5201/hovercard?comment_id=2086125665&comment_type=review_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r2086125665">#5201 (comment)</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6313#pullrequestreview-3108832758">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJBBIG6PQRTQISNJ533NGGWZAVCNFSM6AAAAACDRTVSROVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMBYHAZTENZVHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLY2YTFRVUV74REBBT3NGGWZA5CNFSM6AAAAACDRTVSROWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTVZJUC7M.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6313/review/3108832758</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6313#pullrequestreview-3108832758",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6313#pullrequestreview-3108832758",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>