<p></p>
<p><b>@AntonKhorev</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6318#discussion_r2273921120">test/controllers/user_blocks_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -421,7 +421,7 @@ def test_create
post user_blocks_path
assert_response :not_found
assert_template "users/no_such_user"
- assert_select "h1", "The user does not exist"
+ assert_select "h1", "The user does not exist"
</pre>
<p dir="auto">This breaks because the message itself doesn't make sense, if we take i18n into account. There's an empty username with spaces around it. Temporarily I'd do <code class="notranslate">:html</code> fix like in <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6318/files#r2273910522">changesets_helper_test</a> because it allows commits to be in a different order.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6318#pullrequestreview-3116675579">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPB3QBND7H2VNFLDHD3NNO2XAVCNFSM6AAAAACDXIK6KGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJWGY3TKNJXHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6318/review/3116675579</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6318#pullrequestreview-3116675579",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6318#pullrequestreview-3116675579",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>