<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/5842757?s=20&v=4" /><strong>mmd-osm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6326#issuecomment-3198171654">(openstreetmap/openstreetmap-website#6326)</a></div>
<p dir="auto">I'm a bit lost how the normalisation is supposed to work - without changing anything on the db schema. I tried to use   <code class="notranslate">has_many :element_tags, :as => :relation_tags</code>, but PostgreSQL was complaining about some unknown columns/types.</p>
<p dir="auto">In the meantime, the previous code is now a bit more generic, and derives associations from class names. I think that's not too bad.</p>
<div class="highlight highlight-source-ruby" dir="auto"><pre class="notranslate">  <span class="pl-k">def</span> <span class="pl-en">prefetch_member_tags</span><span class="pl-kos">(</span><span class="pl-s1">feature</span><span class="pl-kos">)</span>
    <span class="pl-s1">members</span> <span class="pl-c1">=</span> <span class="pl-s1">feature</span><span class="pl-kos">.</span><span class="pl-en">relation_members</span><span class="pl-kos">.</span><span class="pl-en">filter_map</span><span class="pl-kos">(</span>&<span class="pl-pds">:member</span><span class="pl-kos">)</span>

    <span class="pl-s1">members</span><span class="pl-kos">.</span><span class="pl-en">group_by</span><span class="pl-kos">(</span>&<span class="pl-pds">:class</span><span class="pl-kos">)</span><span class="pl-kos">.</span><span class="pl-en">each</span> <span class="pl-k">do</span> |<span class="pl-s1">klass</span><span class="pl-kos">,</span> <span class="pl-s1">records</span>|
      <span class="pl-s1">association</span> <span class="pl-c1">=</span> <span class="pl-pds">:"<span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-s1">klass</span><span class="pl-kos">.</span><span class="pl-en">name</span><span class="pl-kos">.</span><span class="pl-en">downcase</span><span class="pl-kos">}</span></span>_tags"</span>

      <span class="pl-v">ActiveRecord</span>::<span class="pl-v">Associations</span>::<span class="pl-v">Preloader</span><span class="pl-kos">.</span><span class="pl-en">new</span><span class="pl-kos">(</span>
        <span class="pl-pds">:records</span> <span class="pl-c1">=></span> <span class="pl-s1">records</span><span class="pl-kos">,</span>
        <span class="pl-pds">:associations</span> <span class="pl-c1">=></span> <span class="pl-s1">association</span>
      <span class="pl-kos">)</span><span class="pl-kos">.</span><span class="pl-en">call</span>
    <span class="pl-k">end</span>
  <span class="pl-k">end</span></pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6326#issuecomment-3198171654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLM57LTF2GJMWFQV6633OITZNAVCNFSM6AAAAACEAHLNVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOJYGE3TCNRVGQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6326/c3198171654</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6326#issuecomment-3198171654",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6326#issuecomment-3198171654",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>