<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/360803?s=20&v=4" /><strong>gravitystorm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6393#issuecomment-3303893868">(openstreetmap/openstreetmap-website#6393)</a></div>
<p dir="auto">Thanks, merged.</p>
<blockquote>
<p dir="auto">Generally fixing <code class="notranslate">Gemfile.lock</code> conflicts just means deleting the conflicts and running <code class="notranslate">bundle install</code> to fix things I think?</p>
</blockquote>
<p dir="auto">I mean yes, that's how I've done it before (roughly <code class="notranslate">git merge</code>, manually fix conflicts, run <code class="notranslate">bundle install</code> again just in case, <code class="notranslate">git add</code>, <code class="notranslate">git merge --continue</code>, <code class="notranslate">git push upstream master</code>, which means my lockfile fixes are hidden in the merge commit. But it also means that I push the merge commit to master without that having gone through CI, and that makes me nervous.</p>
<p dir="auto">Whereas if there's a way to check out the branch locally, twiddle stuff (e.g. <code class="notranslate">git rebase</code> + lockfile cleanup), and then push the new commit back to the PR, I could let CI run and then use the Github UI to do the merge when CI is green. I <em>think</em> I've done this before (and managed to preserve the commit authorship). But I also know it doesn't work if the PR submitter has unticked the "let maintainers write to this branch" option, and it even if that's ticked it can be a faff to set up the correct remote to push to since you can't (afaik) push to the <code class="notranslate">pull/1234</code> branch on origin, you have to set up and push to the <code class="notranslate">someone</code> remote, with whatever branch they've used to make the PR. And I've messed that up too in the past, by pushing the wrong thing to the branch on someone else's repo, which is a bit embarrassing.</p>
<p dir="auto">So if there's an easier way to do option 2, with less faffing with the various <code class="notranslate">remotes</code>, or a different way entirely, then that would be great.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6393#issuecomment-3303893868">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL2C73M6NB24ZOS2I33TGJEVAVCNFSM6AAAAACGPJ75TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBTHA4TGOBWHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIW4NOCHCN3N5DFZP33TGJEVA5CNFSM6AAAAACGPJ75TGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWE5VVWY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6393/c3303893868</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6393#issuecomment-3303893868",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6393#issuecomment-3303893868",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>