<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/360803?s=20&v=4" /><strong>gravitystorm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3303260329">(openstreetmap/openstreetmap-website#6151)</a></div>
<p dir="auto">I agree with <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a> on this. It sort of vaguely makes sense, in principle, to cancel the other jobs when one fails, except for two key things that happen in reality:</p>
<ul dir="auto">
<li>Our jobs only fail at the end. We run the entire test suite to completion, rather than failing early if a single test fails (i.e. <code class="notranslate">bundle exec rails test</code> not <code class="notranslate">bundle exec rails test --fail-fast</code>. So, as <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a> discusses, it's likely that if one job fails, the other jobs are very nearly close to finishing anyway.</li>
<li>Our jobs usually fail for "transient bug in test suite" reasons, much more than "this PR has a coding mistake" reasons. I use the "re-run failed tests" options all the time, both on PRs and on our master branch, when I see that there was a CI failure. So when one spurious job failure cancels the others, we're re-running jobs that were definitely nearly finished and probably were going to pass. (One caveat is that I don't know how often the coveralls failures would affect all three jobs completing close together, maybe the failures will be correlated on that).</li>
</ul>
<p dir="auto">So thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/hlfan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/hlfan">@hlfan</a> , merged.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3303260329">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLTFDOMSHMBJAD7DNL3TFVG3AVCNFSM6AAAAACAOKEHD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBTGI3DAMZSHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIWPECGIBWMEFVYPB33TFVG3A5CNFSM6AAAAACAOKEHD2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWE4PAKS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6151/c3303260329</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3303260329",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6151#issuecomment-3303260329",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>