<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>
<p dir="auto">I agree it's worth having a warning for this link. It would be even better if the link was to the third-party website, for example pre-populating a form or something similar. That website could then take care of things like formats, warnings, etc.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2375255566">app/assets/javascripts/index/export.js</a>:</p>
<pre style='color:#555'>> @@ -37,6 +37,55 @@ OSM.Export = function (map) {
validateControls();
}
+ async function showConfirmationModal(message) {
+ return new Promise((resolve) => {
+ const modalHtml = `
</pre>
<p dir="auto">This block of html should be in a erb view template. It might make sense to put it in the same view template as the overpass api link, since they are closely related.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2375257435">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -3531,6 +3531,11 @@ en:
filename: "map"
embed:
report_problem: "Report a problem"
+ export:
+ header: Confirm
</pre>
<p dir="auto">This should describe the subject of the body, for example "Download XML Data" or something similar</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2375265680">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -3531,6 +3531,11 @@ en:
filename: "map"
embed:
report_problem: "Report a problem"
+ export:
+ header: Confirm
+ body: Do you want to download map data for this area in XML format? Note that large areas may take some time to download.
+ cancel: Cancel
+ ok: OK
</pre>
<p dir="auto">Please avoid using "OK" as button text. Instead we should use a verb for the action being taken, e.g. "Download" - see e.g. <a href="https://ux.stackexchange.com/a/9960" rel="nofollow">https://ux.stackexchange.com/a/9960</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3262131595">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIGVU5LINMSBVX4WC33UJUYRAVCNFSM6AAAAACHGADBFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENRSGEZTCNJZGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOMW4ZR77W5QONLERD3UJUYRA5CNFSM6AAAAACHGADBFOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWCOAWYW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6411/review/3262131595</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3262131595",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3262131595",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>