<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6412#discussion_r2376204598">app/assets/javascripts/application.js</a>:</p>
<pre style='color:#555'>> +
+ if ($search.length) {
+ $search.off("input");
+ $search.on("input", function () {
+ const query = $(this).val().toLowerCase();
+ $(".language-item").each(function () {
+ const text = $(this).text().toLowerCase();
+ $(this).toggle(text.indexOf(query) > -1);
+ });
+ });
+ }
+ }
+ });
+
+ $("#select_language_dialog").on("shown.bs.modal", function () {
+ $("#language_search").val("").trigger("input");
</pre>
<p dir="auto">Would it make sense to grab the focus so that the user can start typing straightaway?</p>
⬇️ Suggested change
<pre style="color: #555">- $("#language_search").val("").trigger("input");
+ $("#language_search")
+ .focus()
+ .val("").trigger("input");
</pre>
<p dir="auto">(I'm not an accessibility expert, so I might be proposing an a11y sin here).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6412#pullrequestreview-3263502205">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLNGRDWBIFK25Q6Y2P33UK23TAVCNFSM6AAAAACHGBLHKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENRTGUYDEMRQGU">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLP2OMY6LWOGHDTYZZT3UK23TA5CNFSM6AAAAACHGBLHKCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWCQULX2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6412/review/3263502205</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6412#pullrequestreview-3263502205",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6412#pullrequestreview-3263502205",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>