<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2381441055">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -2623,6 +2620,11 @@ en:
           description: "Additional sources listed on the OpenStreetMap Wiki"
       export_button: "Export"
       export_download: "Downloading..."
+      confirmation:
+        header: Download XML Data
+        body: Do you want to download map data for this area in XML format? Note that large areas may take some time to download.
+        cancel: Cancel
+        ok: Download
</pre>
<p dir="auto">Should the key also be <code class="notranslate">download</code>, to better reflect the intent? And also the id, variable, function, etc. Nitpicky, but I think it's worth having the code describe the action, adding clarity.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2381534928">app/assets/javascripts/index/export.js</a>:</p>
<pre style='color:#555'>> @@ -37,6 +37,28 @@ OSM.Export = function (map) {
     validateControls();
   }
 
+  async function showConfirmationModal() {
+    const $modal = $("#export_confirmation");
+    const $okButton = $("#ok_button");
</pre>
<p dir="auto">I'm thinking that this is a bit generic to get an id on its own. A different modal could be added in the future that also has <code class="notranslate">id="ok_button"</code> (or whatever name it receives, as per my other comment). Perhaps this should be handled with a class? Like this:</p>
⬇️ Suggested change
<pre style="color: #555">-    const $okButton = $("#ok_button");
+    const $okButton = $modal.find(".ok_button");
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3270948026">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJCBFZOCYPDIDCRZW33UUAK5AVCNFSM6AAAAACHGADBFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZQHE2DQMBSGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLLDTCES6HLLZIBUZYD3UUAK5A5CNFSM6AAAAACHGADBFOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWC622LU.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6411/review/3270948026</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3270948026",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6411#pullrequestreview-3270948026",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>