<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2383242535">app/assets/javascripts/index/export.js</a>:</p>
<pre style='color:#555'>> @@ -37,6 +37,28 @@ OSM.Export = function (map) {
validateControls();
}
+ async function showConfirmationModal() {
+ const $modal = $("#export_confirmation");
+ const $okButton = $("#ok_button");
</pre>
<p dir="auto">What I mean is that, technically, an id should be unique to the whole page. So if there's another <code class="notranslate">id="download_button"</code> in the future, that will be against the HTML standard and perhaps malfunction with some DOM implementation. With a class, we can have as many <code class="notranslate">.download_button</code> as we wish in the same page.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2383242535">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKGTE2CI4SNQEFP2YL3UWERHAVCNFSM6AAAAACHGADBFOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZTGUZTKMBXGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIBWPLWDE5DVSCTXZ33UWERHA5CNFSM6AAAAACHGADBFOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWDDYXGC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6411/review/3273535073</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2383242535",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6411#discussion_r2383242535",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>