<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6410#discussion_r2384164989">app/assets/javascripts/index/contextmenu.js</a>:</p>
<pre style='color:#555'>> @@ -1,80 +1,200 @@
+/* global Popper */
</pre>
<p dir="auto">Other global declarations are in <code class="notranslate">config/eslint.config.mjs</code> rather than being done on a per-file basis like this?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6410#discussion_r2384165483">app/assets/javascripts/index/contextmenu.js</a>:</p>
<pre style='color:#555'>>  
-  const updateMenu = function updateMenu() {
-    map.contextmenu.setDisabled(2, map.getZoom() < 12);
-    map.contextmenu.setDisabled(4, map.getZoom() < 14);
-  };
+  OSM.renderContextMenu($contextMenu, contextmenuItems);
+};
+
+OSM.createSeparator = function () {
</pre>
<p dir="auto">This (and <code class="notranslate">createMenuItem</code> and <code class="notranslate">renderContextMenu</code>) are only used from <code class="notranslate">initializeContextMenu</code> at the moment so they could just be declared in there rather than being exported in the <code class="notranslate">OSM</code> namespace unless you're expecting to be using them somewhere else?</p>
<p dir="auto">Though I guess they may go away if you switch to rendering the menu on the server.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6410#pullrequestreview-3274933178">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJZU7U42VWURSKNIZ33U2GJBAVCNFSM6AAAAACHFZX7N6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZUHEZTGMJXHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNV5UYOOXUOIIEAZRD3U2GJBA5CNFSM6AAAAACHFZX7N6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWDGOB3U.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6410/review/3274933178</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6410#pullrequestreview-3274933178",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6410#pullrequestreview-3274933178",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>