<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/36066?s=20&v=4" /><strong>pablobm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3365300937">(openstreetmap/openstreetmap-website#6424)</a></div>
<p dir="auto">Another funny one. Relevant commit: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/cf421c07312452af6e28f6924dc019ad4c3c33db/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/cf421c07312452af6e28f6924dc019ad4c3c33db"><tt>cf421c0</tt></a>. The test <a href="https://github.com/openstreetmap/openstreetmap-website/blob/4191555f2846ac6e6f353b29c7d48f9ef9261efb/test/system/select_language_test.rb">test/system/select_language_test.rb</a> fails with remote Selenium because there is no HTTPS, and therefore it can't set "secure" cookies.</p>
<p dir="auto">I'm ignorant on this topic: should we bother with secure cookies? We force HTTPS anyway 🤔 Alternatively, we could have a setting in the JS that announces whether we are in production mode, and then set <code class="notranslate">secure: true</code> or not depending on that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3365300937">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLO2BBYJD6JVKRXW6633VZLD7AVCNFSM6AAAAACIAUD6DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNRVGMYDAOJTG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIJFWCZYVUYQJ3SPXT3VZLD7A5CNFSM6AAAAACIAUD6DKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWISZVMS.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6424/c3365300937</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>

<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3365300937",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3365300937",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>