<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/36066?s=20&v=4" /><strong>pablobm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3366166757">(openstreetmap/openstreetmap-website#6424)</a></div>
<p dir="auto">Right, that's all tests passing under the devcontainer, on my Mac and on CI. Other environments yet to be tested.</p>
<p dir="auto">I solved the issue with the cookies using <code class="notranslate">OSM.SERVER_PROTOCOL</code> as suggested. I also did a refactor to DRY up the cookie handling. Another candidate for a separate PR? Commit: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/60af1a16111da236fadeba9fa432408479ddc6fb/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/60af1a16111da236fadeba9fa432408479ddc6fb"><tt>60af1a1</tt></a></p>
<p dir="auto">Still a few todo items to go through, plus the open questions. Non-devcontainers tests are failing because I'm missing a cleanup: I didn't want to commit too much time on that, just in case there are concerns about the caveats.</p>
<p dir="auto">If you have opinions, I'd love to hear them!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3366166757">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOUKJGRCU6YVYVTDFT3V2ICRAVCNFSM6AAAAACIAUD6DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNRWGE3DMNZVG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPG2E3KWBQAZQ5PKND3V2ICRA5CNFSM6AAAAACIAUD6DKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWIUOQOK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6424/c3366166757</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3366166757",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3366166757",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>