<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<p dir="auto">I think the cookies clean up doesn't need that much of investigation ahead of pulling it into its own PR.</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#discussion_r2403840825">.github/workflows/devcontainer.yml</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,17 @@
+name: devcontainer
+
+on:
+ - push
+ - pull_request
+
</pre>
<p dir="auto">Could the superseded workflow cancellation work here too?</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#discussion_r2403841333">app/assets/javascripts/osm.js.erb</a>:</p>
<pre style='color:#555'>> @@ -27,6 +27,8 @@ OSM = {
end.to_json
%>,
+ COOKIES: Cookies.withAttributes({ path: "/", samesite: "lax", secure: <%= (Settings.server_protocol == "https").to_json %> }),
</pre>
<p dir="auto">Since this isn't a constant, I'd like it to be in lowercase.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6424#pullrequestreview-3301671767">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLMTCN7T4TBD2OSU5XD3V572TAVCNFSM6AAAAACIAUD6DKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBRGY3TCNZWG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNR4EPRQWHQZC2TBB33V572TA5CNFSM6AAAAACIAUD6DKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWEZOBVO.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6424/review/3301671767</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6424#pullrequestreview-3301671767",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6424#pullrequestreview-3301671767",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>