<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6429#discussion_r2407766333">test/integration/oauth2_test.rb</a>:</p>
<pre style='color:#555'>> @@ -110,7 +110,7 @@ def test_openid_connect
     end
 
     assert_equal user.id.to_s, data["sub"]
-    assert_not data.key?("preferred_username")
</pre>
<p dir="auto">Well I think it was always meant to be there - what else is that line there for?</p>
<p dir="auto">The discussion in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1880361505" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/4226" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/4226/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/4226">#4226</a> all seems to suggest it was intended to be there and the commit message for <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/openstreetmap/openstreetmap-website/commit/64bcf7652bc1053741ab58f3ff54505b3d7820ad/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/commit/64bcf7652bc1053741ab58f3ff54505b3d7820ad"><tt>64bcf76</tt></a> says it's returned as a claim for the openid scope...</p>
<p dir="auto">Quite why that assertion wound up asserting the opposite I'm not sure!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6429#discussion_r2407766333">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLKTH46L3RLJEU6BCS33WKVWRAVCNFSM6AAAAACIK7AFICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBWGM4DKNZQHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOQ7H23HND757LL5TT3WKVWRA5CNFSM6AAAAACIK7AFICWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWFCNYS2.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6429/review/3306385709</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6429#discussion_r2407766333",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6429#discussion_r2407766333",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>