<p></p>
<p><b>@gravitystorm</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2414186164">bin/setup</a>:</p>
<pre style='color:#555'>> @@ -17,6 +17,9 @@ FileUtils.chdir APP_ROOT do
   puts "== Installing dependencies =="
   system("bundle check") || system!("bundle install")
 
+  # Install JavaScript dependencies
+  system("yarn install --check-files")
+
</pre>
<p dir="auto">We use <code class="notranslate">bundle exec bin/yarn install</code> in the install notes, Docker file, and vagrant provisioning, and so I would expect this to be consistent with those.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2414202517">db/seeds.rb</a>:</p>
<pre style='color:#555'>> @@ -9,3 +9,39 @@
 #   Character.create(name: 'Luke', movie: movies.first)
 
 Language.load(Rails.root.join("config/languages.yml"))
+
+def log(*)
+  puts(*) # rubocop:disable Rails/Output
+end
+
+display_name = "admin"
+password = "openstreetmap"
+email = "admin_#{SecureRandom.uuid}@example.com"
+role = "administrator"
+
+admin = User.find_or_create_by!(:display_name => display_name) do |user|
</pre>
<p dir="auto">We should avoid putting non-essential data into the seeds file. This file should only contain the data that's essential to running the site, in all deployments, since the seeds can be run in all environments (test, development and production). These seeds can end up in production databases, perhaps inadvertently, depending on which commands a sysadmin users to set up the database.</p>
<p dir="auto">See <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="777512526" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/3030" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/3030/hovercard?comment_id=755458958&comment_type=issue_comment" href="https://github.com/openstreetmap/openstreetmap-website/pull/3030#issuecomment-755458958">#3030 (comment)</a> for more details on this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#pullrequestreview-3315298708">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJ63OHTBPZY756JM6T3WUSQVAVCNFSM6AAAAACIQUCAKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJVGI4TQNZQHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMHYOKQK2SFFMHHWZL3WUSQVA5CNFSM6AAAAACIQUCAKCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWFTNYZI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6432/review/3315298708</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6432#pullrequestreview-3315298708",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6432#pullrequestreview-3315298708",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>