<p></p>
<p><b>@gravitystorm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416357045">bin/setup</a>:</p>
<pre style='color:#555'>> @@ -17,6 +17,9 @@ FileUtils.chdir APP_ROOT do
puts "== Installing dependencies =="
system("bundle check") || system!("bundle install")
+ # Install JavaScript dependencies
+ system("yarn install --check-files")
+
</pre>
<p dir="auto">I'm happy to align with upstream. My main concern, by far, is to make sure that what is written in the install notes (including any options) is as close to possible as what is done in CI. We've had so many cases over the years where the install notes don't work, and we haven't noticed because CI was doing something subtly different, and who knows how many people tried and failed before anyone contacted us.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416357045">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOG4D53BXZBJJ37CWD3WY377AVCNFSM6AAAAACIQUCAKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJYGM2DCMBRGM">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJHOSTV4Y4EWXRROOL3WY377A5CNFSM6AAAAACIQUCAKCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWFZHOZK.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6432/review/3318341013</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416357045",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416357045",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>