<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416321423">bin/setup</a>:</p>
<pre style='color:#555'>> @@ -17,6 +17,9 @@ FileUtils.chdir APP_ROOT do
   puts "== Installing dependencies =="
   system("bundle check") || system!("bundle install")
 
+  # Install JavaScript dependencies
+  system("yarn install --check-files")
+
</pre>
<p dir="auto">How about going the other way around?</p>
<ul dir="auto">
<li>From the discussion at <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="478024428" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/2344" data-hovercard-type="issue" data-hovercard-url="/openstreetmap/openstreetmap-website/issues/2344/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/issues/2344">#2344</a>, I think we agree that we can drop Vagrant, so let's do that: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3498527172" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6438" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/6438/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/6438">#6438</a>.</li>
<li>Then there's the devcontainer support coming up (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3474165426" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/6424" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/6424/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/6424">#6424</a>) which will lead to dropping the "manual" Docker option and related files.</li>
<li>The install notes are slightly different: it makes sense to simplify them and therefore we can remove the <code class="notranslate">--check-files</code> option.</li>
<li>Then there's the <code class="notranslate">bin/update</code> script comes from the update to Rails 5.2.0. Nowadays you do <code class="notranslate">rails app:update</code>, I think that can be removed too (different PR).</li>
</ul>
<p dir="auto">All this is in the spirit of trying to stay as similar to stock Rails as possible, which will help in future updates.</p>
<p dir="auto">Thoughts?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416321423">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJLHQK6M2HLTUEUEKL3WY2NDAVCNFSM6AAAAACIQUCAKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMJYGI4DEOBZG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJSWF6N3BPX4UXNZX33WY2NDA5CNFSM6AAAAACIQUCAKCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWFZD5JC.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6432/review/3318282897</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416321423",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6432#discussion_r2416321423",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>