<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>
<p dir="auto">Looks great to me!</p><hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6449#discussion_r2433699258">test/mailers/previews/user_mailer_preview.rb</a>:</p>
<pre style='color:#555'>> +class UserMailerPreview < ActionMailer::Preview
+ include FactoryBot::Syntax::Methods
+
+ # Wraps the preview in a transaction, so that no changes
+ # are persisted to the development db
+ def self.call(...)
+ preview = nil
+ ActiveRecord::Base.transaction do
+ preview = super(...)
+ raise ActiveRecord::Rollback
+ end
+ preview
+ end
+
+ def diary_comment_notification
+ recipient = create(:user)
</pre>
<p dir="auto">This should probably set the user language so that the local selector in the preview works - something like:</p>
⬇️ Suggested change
<pre style="color: #555">- recipient = create(:user)
+ recipient = create(:user, :languages => [I18n.locale])
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6449#pullrequestreview-3341932718">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLIA6HUVGXVOZCADHZT3X2NWJAVCNFSM6AAAAACJJASA52VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBRHEZTENZRHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPFIPA7E4VMJ6LFBAL3X2NWJA5CNFSM6AAAAACJJASA52WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWHGHMK4.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6449/review/3341932718</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6449#pullrequestreview-3341932718",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6449#pullrequestreview-3341932718",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>