<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6452#discussion_r2459486958">test/controllers/api/users_controller_test.rb</a>:</p>
<pre style='color:#555'>> +        js_links = js.dig("user", "social_links")
+        assert_equal user.social_links.count, js_links.count
+        user.social_links.each do |user_link|
+          details = user_link.parsed
+          matching_js_link = js_links.find { |js_link| 
+            js_link["url"] == details[:url] && js_link["platform"] == details[:platform] 
+          }
+          assert_not_nil matching_js_link
+        end
</pre>
<p dir="auto">Alternatively, you can sort them first and avoid the nested loop:</p>
⬇️ Suggested change
<pre style="color: #555">-        js_links = js.dig("user", "social_links")
-        assert_equal user.social_links.count, js_links.count
-        user.social_links.each do |user_link|
-          details = user_link.parsed
-          matching_js_link = js_links.find { |js_link| 
-            js_link["url"] == details[:url] && js_link["platform"] == details[:platform] 
-          }
-          assert_not_nil matching_js_link
-        end
+        ordered_js_links = js.dig("user", "social_links").sort_by { |link| link["url"] }
+        ordered_user_links = user.social_links.sort_by(&:url).map(&:parsed)
+
+        assert_equal ordered_user_links.count, ordered_js_links.count
+
+        ordered_user_links.zip(ordered_js_links).each do |user_link, js_link|
+          assert_equal user_link[:url], js_link["url"]
+          assert_equal user_link[:platform], js_link["platform"]
+        end
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6452#pullrequestreview-3375346882">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLLFDJQENVM7FCP3S233ZHWAPAVCNFSM6AAAAACJQJULC6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNZVGM2DMOBYGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLKUAAIYB3OEOBOXSBD3ZHWAPA5CNFSM6AAAAACJQJULC6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWJF62ME.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6452/review/3375346882</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6452#pullrequestreview-3375346882",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6452#pullrequestreview-3375346882",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>