<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/360803?s=20&v=4" /><strong>gravitystorm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6410#issuecomment-3461974688">(openstreetmap/openstreetmap-website#6410)</a></div>
<p dir="auto">This looks great, and I'm happy to merge it as-is.</p>
<p dir="auto">I'm happy to see the bootstrap-icons dependency, and I hope this makes it easier for other developers to add icons elsewhere in the site, where they are useful.</p>
<p dir="auto">I'm going to create a follow-up issue about making our icons more consistent, since several items on the menu have icons which don't match the icons elsewhere in the UI. However, I didn't feel like these inconsistencies should block the merging of this PR, which was substantially concerned with changing the implementation. We can discuss and iterate the icons separately.</p>
<p dir="auto">I also agree with Tom that it would be good to make the html generated in a view, where it's easier for most developers to find and adjust, but that can also be tackled separately.</p>
<p dir="auto">Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mmd-osm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mmd-osm">@mmd-osm</a> for your work on this!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6410#issuecomment-3461974688">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOFL6QRR3WFC7ETFID32DHV5AVCNFSM6AAAAACHFZX7N6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINRRHE3TINRYHA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLOIOA6JMIOCJG5GXF332DHV5A5CNFSM6AAAAACHFZX7N6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWOLGFKA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6410/c3461974688</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6410#issuecomment-3461974688",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6410#issuecomment-3461974688",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>