<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<p dir="auto">I'm generally in favour of this change, although I want to highlight that there will be subtle changes to some icons. In particular some appear to be a bit smaller. Just so that we all know what this exactly entails.</p>
<p dir="auto">This is three of them. Note that I have also seen some that appear completely unchanged:</p>
<markdown-accessiblity-table><table role="table">
<thead>
<tr>
<th>Where</th>
<th>Current</th>
<th>Proposed</th>
</tr>
</thead>
<tbody>
<tr>
<td>New Diary Entry</td>
<td><a href="https://github.com/user-attachments/assets/b510e6d4-9129-4a2f-995a-01cbfc471b4f">new-diary-entry-current.png (view on web)</a></td>
<td><a href="https://github.com/user-attachments/assets/baff961f-4955-43ea-aa76-d1f5f75000e1">new-diary-entry-proposed.png (view on web)</a></td>
</tr>
<tr>
<td>Latest Diaries</td>
<td><a href="https://github.com/user-attachments/assets/a359b158-7e6f-4efa-aec3-6977388c30e7">latest-diaries-current.png (view on web)</a></td>
<td><a href="https://github.com/user-attachments/assets/6ff3a735-1191-4cf8-93d4-1a91c773b3db">latest-diaries-proposed.png (view on web)</a></td>
</tr>
<tr>
<td>Company icon</td>
<td><a href="https://github.com/user-attachments/assets/412fa741-9b38-4b1e-8c08-903de8bc8a48">company-current.png (view on web)</a></td>
<td><a href="https://github.com/user-attachments/assets/7ba387c5-0a5d-478b-afc7-2358471f6e8b">company-proposed.png (view on web)</a></td>
</tr>
</tbody>
</table></markdown-accessiblity-table>
<p dir="auto">That's as rendered by Firefox 140.4.0esr with Debian 13 on old hardware.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6487#discussion_r2477552831">test/system/profile_company_change_test.rb</a>:</p>
<pre style='color:#555'>> @@ -43,7 +43,7 @@ class ProfileCompanyChangeTest < ApplicationSystemTestCase
     assert_text "Profile company updated."
 
     within_content_body do
-      assert_text :all, "Company Test Co."
</pre>
<p dir="auto">I was scratching my head about these changes for a minute. Now I see that the <code class="notranslate">title</code> argument was being injected into the SVG to serve as <code class="notranslate"><title></code> tag within it.</p>
<p dir="auto">Is there an accessibility impact? Do user agents read the <code class="notranslate"><title></code> in the SVG? If so, are we losing an accessibility aid? Should these be replaced with an alt text? Not sure how to do that with Bootstrap icons, a quick search seems to suggest to use <code class="notranslate">.visually-hidden</code> within the <code class="notranslate"><i></code>: <a href="https://getbootstrap.com/docs/5.3/getting-started/accessibility/#visually-hidden-content" rel="nofollow">https://getbootstrap.com/docs/5.3/getting-started/accessibility/#visually-hidden-content</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6487#pullrequestreview-3398908367">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOBAMCRK72EJFEXGXT32HXNLAVCNFSM6AAAAACKTGOBLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGOJYHEYDQMZWG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJUPTHYKJ4AHYAAONL32HXNLA5CNFSM6AAAAACKTGOBLGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWKS4446.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6487/review/3398908367</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6487#pullrequestreview-3398908367",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6487#pullrequestreview-3398908367",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>