<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#discussion_r2486170761">app/views/site/id.html.erb</a>:</p>
<pre style='color:#555'>> @@ -13,7 +13,7 @@
      data[:token] = token.token
    end
    data[:locale] = ID::LOCALES.preferred(preferred_languages).to_s
-   data[:theme] = (preferred_color_scheme(:site) if preferred_color_scheme(:site) != "auto")
+   data[:theme] = (preferred_color_scheme(:editor) if preferred_color_scheme(:editor) != "auto") || (preferred_color_scheme(:site) if preferred_color_scheme(:site) != "auto")
</pre>
<p dir="auto">This got too complex here. Let's move it to a helper, preferably with a test.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#discussion_r2486178408">app/views/preferences/basic_preferences/show.html.erb</a>:</p>
<pre style='color:#555'>> @@ -32,5 +32,13 @@
                    :class => "form-select" %>
   </div>
 
+  <div class="mb-3">
+    <%= label_tag "editor_color_scheme", t(".preferred_editor_color_scheme"), :class => "form-label" %>
+    <%= select_tag "editor_color_scheme",
+                   options_for_select(%w[auto light dark].map { |scheme| [t(".editor_color_schemes.#{scheme}"), scheme] },
</pre>
<p dir="auto">The user-facing label "auto" is not clear enough here. There can be confusion as to how three dropdowns relate to each other. How about labelling it as "same as Website" on both <code class="notranslate">:editor</code> and <code class="notranslate">:map</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#pullrequestreview-3410599357">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLL4WH4M2H7ZTMGLCUL3245J5AVCNFSM6AAAAACK54KIVGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMJQGU4TSMZVG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLIKLZ5TOR7KYFU444D3245J5A5CNFSM6AAAAACK54KIVGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWLJGO32.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6492/review/3410599357</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6492#pullrequestreview-3410599357",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6492#pullrequestreview-3410599357",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>