<p></p>
<p><b>@hlfan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#discussion_r2492571312">app/controllers/application_controller.rb</a>:</p>
<pre style='color:#555'>> @@ -275,11 +275,12 @@ def preferred_editor
end
def preferred_color_scheme(subject)
- if current_user
- current_user.preferences.find_by(:k => "#{subject}.color_scheme")&.v || "auto"
- else
- "auto"
- end
+ scheme = current_user ? current_user.preferences.find_by(:k => "#{subject}.color_scheme")&.v : nil
</pre>
<p dir="auto">Only with offending RuboCop. But not going into the subjects loop seems even better.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#discussion_r2492571312">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPKA3JLBAIG7SWTNIL33FLFHAVCNFSM6AAAAACK54KIVGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMJZGMZTENJQGI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLPLAU2CDYV63USDN3L33FLFHA5CNFSM6AAAAACK54KIVGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWLZ3PZM.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6492/review/3419332502</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6492#discussion_r2492571312",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6492#discussion_r2492571312",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>