<div style="display: flex; flex-wrap: wrap; white-space: pre-wrap; align-items: center; "><img height="20" width="20" style="border-radius:50%; margin-right: 4px;" decoding="async" src="https://avatars.githubusercontent.com/u/36066?s=20&v=4" /><strong>pablobm</strong> left a comment <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#issuecomment-3491093576">(openstreetmap/openstreetmap-website#6492)</a></div>
<p dir="auto">For things like this, I'd suggest to move code to models (or dedicated Ruby classes) where they can be tested thoroughly without too much ceremony.</p>
<p dir="auto">Here's an example: <a class="commit-link" href="https://github.com/hlfan/openstreetmap-website/compare/editor-theme...pablobm:openstreetmap-website:editor-theme">hlfan/openstreetmap-website@<tt>editor-theme...pablobm:openstreetmap-website:editor-theme</tt></a> The second commit is refactor idea, take it or leave it.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6492#issuecomment-3491093576">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLJFSRMNGECAAP4NGS333HYRLAVCNFSM6AAAAACK54KIVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOJRGA4TGNJXGY">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLNZWQIKZJNHP5DOE7333HYRLA5CNFSM6AAAAACK54KIVGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTWQCXOEQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6492/c3491093576</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6492#issuecomment-3491093576",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6492#issuecomment-3491093576",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>