<p></p>
<p><b>@pablobm</b> commented on this pull request.</p>

<p dir="auto">Tested in my machine and looks great. Even gave the globe view a whirl 🙂 I'll leave to others to review though as I'm sure there's tricky, non-obvious stuff.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6504#discussion_r2499118341">app/assets/stylesheets/maplibre-gl-all.scss</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,6 @@
+
+/*
+ *= require maplibre-gl
+ */
+
+/* BASED ON leaflet-all.scss */
</pre>
<p dir="auto">This comment probably can go. (I see it's like this in OHM.)</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6504#discussion_r2499127700">test/system/dashboard_test.rb</a>:</p>
<pre style='color:#555'>> @@ -62,7 +62,7 @@ class DashboardSystemTest < ApplicationSystemTestCase
       assert_no_text "Your location"
       assert_no_link "Fred Tester"
 
-      find(".leaflet-marker-icon").click
+      find(".maplibregl-marker", :wait => 60).click
</pre>
<p dir="auto">Was this giving you trouble? 60 seconds sounds a bit excessive to me.</p>

<hr>

<p>On <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6504#discussion_r2499116375">app/assets/stylesheets/maplibre-gl-all.scss</a>:</p>
<p dir="auto">Good question. Personally I would expect the MapLibre styles to live here, but I don't know if there are any historical reasons why it's done differently. It was done like this in the original PR (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="7437976" data-permission-text="Title is private" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/121" data-hovercard-type="pull_request" data-hovercard-url="/openstreetmap/openstreetmap-website/pull/121/hovercard" href="https://github.com/openstreetmap/openstreetmap-website/pull/121">#121</a>) and I can't see an explanation as to why.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3428391359">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLOQYIP7YAYLWHJ27OD33NKANAVCNFSM6AAAAACLKBT5BCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMRYGM4TCMZVHE">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLMT4AKT26RLLT5RGD333NKANA5CNFSM6AAAAACLKBT5BCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWMLEM36.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6504/review/3428391359</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3428391359",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3428391359",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>