<p></p>
<p><b>@tomhughes</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2519258159">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>>        end.html_safe
     end
 
     private
 
+    def expand_link_shorthands(text)
+      linkify_detection_rules = Array.wrap(Settings.linkify&.detection_rules)
+      linkify_detection_rules.each do |rule|
+        next unless rule.path_template && rule.patterns.is_a?(Array)
+
+        rule.patterns.each do |pattern|
+          expanded_path = "#{Settings.server_protocol}://#{rule.host || Settings.server_url}/#{rule.path_template}"
+          text.gsub!(Regexp.new("(?<before>\\s|^|>)#{pattern}(?<after>\\s|$|<)", Regexp::IGNORECASE), "\\k<before>#{expanded_path}\\k<after>")
+        end
+      end
+      [[Settings.linkify_hosts, Settings.linkify_hosts_replacement], [Settings.linkify_wiki_hosts, Settings.linkify_wiki_hosts_replacement]].each do |hosts, replacement|
+        text.gsub!(/(\s)#{Regexp.escape(replacement)}/, "\\1#{Settings.server_protocol}://#{hosts[0]}") if replacement && hosts&.any?
+      end
</pre>
<p dir="auto">Can you explain the purpose of this? It comes from a commit that says "Fix copy-pasting breaking links in linkify" but what exactly is breaking the links and why does this fix it?</p>
<p dir="auto">The PR talks about it rewriting the URL to use a canonical name but wasn't the short name (which you're rewriting from here) supposed to be the canonical name?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2519262528">config/settings.yml</a>:</p>
<pre style='color:#555'>> @@ -139,6 +139,35 @@ fossgis_valhalla_url: "https://valhalla1.openstreetmap.de/route"
 # Endpoints for Wikimedia integration
 wikidata_api_url: "https://www.wikidata.org/w/api.php"
 wikimedia_commons_url: "https://commons.wikimedia.org/wiki/"
+linkify:
+  detection_rules:
+    - patterns: ["node/(?<id>\\d+)", "node (?<id>\\d{5,})", "n(?<id>\\d+)"]
+      path_template: "node/\\k<id>"
+    - patterns: ["way/(?<id>\\d+)", "way (?<id>\\d{5,})", "w(?<id>\\d+)"]
+      path_template: "way/\\k<id>"
+    - patterns: ["relation/(?<id>\\d+)", "relation (?<id>\\d{5,})", "r(?<id>\\d+)"]
+      path_template: "relation/\\k<id>"
+    - patterns: ["changeset/(?<id>\\d+)", "changeset (?<id>\\d{5,})", "cs ?(?<id>\\d{5,})"]
</pre>
<p dir="auto">Why do we allow a space after <code class="notranslate">cs</code> but not after object object types like <code class="notranslate">n</code> or <code class="notranslate">w</code>?</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#discussion_r2519271796">lib/rich_text.rb</a>:</p>
<pre style='color:#555'>>        end.html_safe
     end
 
     private
 
+    def expand_link_shorthands(text)
+      linkify_detection_rules = Array.wrap(Settings.linkify&.detection_rules)
+      linkify_detection_rules.each do |rule|
+        next unless rule.path_template && rule.patterns.is_a?(Array)
+
+        rule.patterns.each do |pattern|
+          expanded_path = "#{Settings.server_protocol}://#{rule.host || Settings.server_url}/#{rule.path_template}"
</pre>
<p dir="auto">It makes sense to combine <code class="notranslate">Settings.server_protocol</code> and <code class="notranslate">Settings.server_url</code> but there's no logical reason it's right combine it with <code class="notranslate">rule.host</code>? Should the rules have a base URL rather than just a host?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/6518#pullrequestreview-3454725787">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAK2OLPRSIUF6DYCGSOZJ5L34NYNZAVCNFSM6AAAAACLXBWDSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINJUG4ZDKNZYG4">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAK2OLJL2QR77OSQE65VPDD34NYNZA5CNFSM6AAAAACLXBWDSCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTWN5LXJW.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><openstreetmap/openstreetmap-website/pull/6518/review/3454725787</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/openstreetmap/openstreetmap-website/pull/6518#pullrequestreview-3454725787",
"url": "https://github.com/openstreetmap/openstreetmap-website/pull/6518#pullrequestreview-3454725787",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>